fix: default --pattern

configure.ac

@@ -14,10 +14,10 @@ if test "x$GCC" = "xyes" && test "x$CC" = "xgcc"; then
 	fi
 fi
 if test "x$ac_cv_env_CFLAGS_set" != "xset"; then
-	CFLAGS="-O2"
+	CFLAGS=""
 fi
 
-STRICT_CFLAGS="-Wall -Wextra -Werror -pipe -Wpedantic -Wconversion -Wshadow"
+STRICT_CFLAGS="-Wall -Wextra -Werror -pipe -Wpedantic -Wconversion -Wshadow -Wvla"
 AC_SUBST([STRICT_CFLAGS])
 
 AM_PROG_AR
@@ -34,6 +34,12 @@ AC_ARG_ENABLE(
 			  [enable_debug=no]
 			  )
 AM_CONDITIONAL([ENABLE_DEBUG], [test "x$enable_debug" = "xyes"])
+AS_IF([test "x$enable_debug" = "xyes"],
+	  [CFLAGS="-g -O0"],
+	  [CFLAGS="-O2"],
+	  )
+
+AC_SUBST([DEBUG_CFLAGS])
 
 
 # --with-bundled-libcli
@@ -95,7 +101,7 @@ AC_MSG_NOTICE([
   ------------------
   PREFIX : $prefix
   CC     : $CC
-  CFLAGS : $STRICT_CFLAGS
+  CFLAGS : $STRICT_CFLAGS $CFLAGS
   tests  : $enable_tests
   debug  : $enable_debug
   libcli : system=$have_system_libcli (forced bundled=$with_bundled_libcli)

libcli

@@ -1 +1 @@
-Subproject commit 7f54a348a5eb5087258e7457452eda32379daac3
+Subproject commit 9f179fa596b1f50007d4995256f47cf5edb4f5dc

libicmp

@@ -1 +1 @@
-Subproject commit ac9ca93d9f0e388c834eae7620bbd4639f2464e4
+Subproject commit 75c5766f00f85d57171bc6c88e4dbe7c4ad6bdd0

src/ping/core/send.c

@@ -81,7 +81,7 @@ fill_payload(uint8_t *payload, size_t len, const struct ping_config *config,
 	if (0 == config->pattern_len)
 	{
 		for (i = offset; i < len; ++i)
-			payload[i] = (uint8_t)('a' + ((i - offset) % 26));
+			payload[i] = (uint8_t)((i - offset) & 0xFF);
 	}
 	else
 	{