refactor(cli): use named constants for return codes and implement flag handlers

includes/cli.h

@@ -3,6 +3,11 @@
 
 #include "ft_ping.h"
 
+#define CLI_SUCCESS			0
+#define CLI_ERROR			1
+#define CLI_EXIT_SUCCESS	-1
+
+
 typedef int (*t_option_handler)(const char *arg, t_ping_config *config);
 
 typedef enum e_option_arg_type

src/cli/handlers/handle_count.c

@@ -1,3 +1,4 @@
+#include "cli.h"
 #include "ft_ping.h"
 
 int
@@ -5,5 +6,5 @@ cli_handle_count(const char *arg, t_ping_config *config)
 {
 	(void)arg;
 	(void)config;
-	return 0;
+	return CLI_SUCCESS;
 }

src/cli/handlers/handle_flood.c

@@ -1,9 +1,11 @@
+#include "cli.h"
 #include "ft_ping.h"
+#include "ft_ping_flags.h"
 
 int
 cli_handle_flood(const char *arg, t_ping_config *config)
 {
 	(void)arg;
-	(void)config;
+	SET_FLAG(config->flags, FLAG_FLOOD);
-	return 0;
+	return CLI_SUCCESS;
 }

src/cli/handlers/handle_help.c

@@ -30,7 +30,7 @@ cli_handle_help(const char *arg, t_ping_config *config)
 				opt->description
 			);
 	}
-	return -1;
+	return CLI_EXIT_SUCCESS;
 }
 
 static const char *

src/cli/handlers/handle_interval.c

@@ -1,3 +1,4 @@
+#include "cli.h"
 #include "ft_ping.h"
 
 int
@@ -5,5 +6,5 @@ cli_handle_interval(const char *arg, t_ping_config *config)
 {
 	(void)arg;
 	(void)config;
-	return 0;
+	return CLI_SUCCESS;
 }

src/cli/handlers/handle_quiet.c

@@ -1,4 +1,5 @@
 #include "ft_ping.h"
+#include "cli.h"
 #include "ft_ping_flags.h"
 
 int
@@ -6,5 +7,5 @@ cli_handle_quiet(const char *arg, t_ping_config *config)
 {
 	(void)arg;
 	SET_FLAG(config->flags, FLAG_QUIET);
-	return 0;
+	return CLI_SUCCESS;
 }

src/cli/handlers/handle_size.c

@@ -1,3 +1,4 @@
+#include "cli.h"
 #include "ft_ping.h"
 
 int
@@ -5,5 +6,5 @@ cli_handle_size(const char *arg, t_ping_config *config)
 {
 	(void)arg;
 	(void)config;
-	return 0;
+	return CLI_SUCCESS;
 }

src/cli/handlers/handle_timeout.c

@@ -1,3 +1,4 @@
+#include "cli.h"
 #include "ft_ping.h"
 
 int
@@ -5,5 +6,5 @@ cli_handle_timeout(const char *arg, t_ping_config *config)
 {
 	(void)arg;
 	(void)config;
-	return 0;
+	return CLI_SUCCESS;
 }

src/cli/handlers/handle_ttl.c

@@ -1,3 +1,4 @@
+#include "cli.h"
 #include "ft_ping.h"
 
 int
@@ -5,5 +6,5 @@ cli_handle_ttl(const char *arg, t_ping_config *config)
 {
 	(void)arg;
 	(void)config;
-	return 0;
+	return CLI_SUCCESS;
 }

src/cli/handlers/handle_version.c

@@ -1,3 +1,4 @@
+#include "cli.h"
 #include "ft_ping.h"
 #include "version_gen.h"
 
@@ -18,5 +19,5 @@ cli_handle_version(const char *arg, t_ping_config *config)
 	printf("\n");
 	printf("Build: %s (commit %s)\n", PING_BUILD_DATE, PING_GIT_COMMIT);
 
-	return -1;
+	return CLI_EXIT_SUCCESS;
 }

src/cli/handlers/hanlde_verbose.c

@@ -1,9 +1,11 @@
+#include "cli.h"
 #include "ft_ping.h"
+#include "ft_ping_flags.h"
 
 int
 cli_handle_verbose(const char *arg, t_ping_config *config)
 {
 	(void)arg;
-	(void)config;
+	SET_FLAG(config->flags, FLAG_VERBOSE);
-	return 0;
+	return CLI_SUCCESS;
 }

src/cli/parse.c

@@ -39,7 +39,7 @@ hanlde_one_option(int opt, char *optarg, t_ping_config *config)
 	int res;
 
 	if ('?' == opt)
-		return 1;
+		return CLI_ERROR;
 	if (NULL != desc)
 	{
 		res = desc->handler(optarg, config);

src/main.c

@@ -3,6 +3,7 @@
 #include <stdlib.h>
 #include <string.h>
 
+#include "cli.h"
 #include "ft_ping.h"
 #include "version_gen.h"
 
@@ -20,7 +21,7 @@ main(int argc, char **argv)
 	if (0 != init_prog_name(argv[0]))
 		return EXIT_FAILURE;
 	ret = cli_parse_arguments(argc, argv, &config);
-	if (ret != 0)
+	if (ret != CLI_SUCCESS)
 		return (ret > 0) ? EXIT_FAILURE : EXIT_SUCCESS;
 
 	printf("PING: Not yet implemented\n");