loic/libicmp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: deduplicate helper function

Browse source
This commit is contained in:
lohhiiccc 2026-01-25 15:48:39 +01:00
parent 7f79d4c8c4
commit 8fb109e2a0
6 changed files with 25 additions and 65 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Makefile
View file

@ -65,7 +65,7 @@ test: $(TEST_BIN)
$(TEST_BIN): $(TESTS) $(OBJS_STATIC) $(TEST_BIN): $(TESTS) $(OBJS_STATIC)
@mkdir -p $(dir $@) @mkdir -p $(dir $@)
$(CC) $(CPPFLAGS) $(CFLAGS) $(TEST_LDFLAGS) $^ -o $@ $(CC) $(CPPFLAGS) -I tests $(CFLAGS) $(TEST_LDFLAGS) $^ -o $@
.PHONY: install .PHONY: install
install: all install: all

16
tests/handle/test_create.c
View file

@ -3,21 +3,7 @@
#include <unistd.h> #include <unistd.h>
#include "icmp.h" #include "icmp.h"
#include "internal/icmp_internal.h" #include "internal/icmp_internal.h"
#include "test_helpers.h"
/* Helper: check if we have CAP_NET_RAW capability */
static int
has_net_raw_capability(void)
{
icmp_handle_t *h = icmp_create();
if (NULL != h)
{
icmp_destroy(h);
return 1;
}
return 0;
}
/* Test 1: icmp_create() success (skip without privileges) */ /* Test 1: icmp_create() success (skip without privileges) */
Test(handle, create_success) Test(handle, create_success)

16
tests/handle/test_destroy.c
View file

@ -4,21 +4,7 @@
#include <stdlib.h> #include <stdlib.h>
#include "icmp.h" #include "icmp.h"
#include "internal/icmp_internal.h" #include "internal/icmp_internal.h"
#include "test_helpers.h"
/* Helper: check if we have CAP_NET_RAW capability */
static int
has_net_raw_capability(void)
{
icmp_handle_t *h = icmp_create();
if (NULL != h)
{
icmp_destroy(h);
return 1;
}
return 0;
}
/* Test 1: icmp_destroy() with NULL handle does not crash */ /* Test 1: icmp_destroy() with NULL handle does not crash */
Test(handle, destroy_null_handle) Test(handle, destroy_null_handle)

16
tests/handle/test_get_fd.c
View file

@ -1,21 +1,7 @@
#include <criterion/criterion.h> #include <criterion/criterion.h>
#include "icmp.h" #include "icmp.h"
#include "internal/icmp_internal.h" #include "internal/icmp_internal.h"
#include "test_helpers.h"
/* Helper: check if we have CAP_NET_RAW capability */
static int
has_net_raw_capability(void)
{
icmp_handle_t *h = icmp_create();
if (NULL != h)
{
icmp_destroy(h);
return 1;
}
return 0;
}
/* Test 1: icmp_get_fd() with NULL handle returns -1 */ /* Test 1: icmp_get_fd() with NULL handle returns -1 */
Test(handle, get_fd_null_handle) Test(handle, get_fd_null_handle)

20
tests/socket/test_socket.c
View file

@ -3,25 +3,7 @@
#include <unistd.h> #include <unistd.h>
#include "internal/icmp_internal.h" #include "internal/icmp_internal.h"
#include "internal/icmp_socket.h" #include "internal/icmp_socket.h"
#include "test_helpers.h"
/* Helper: check if we have CAP_NET_RAW capability */
static int
has_net_raw_capability(void)
{
struct icmp_handle h = {0};
int ret = socket_create(&h);
if (0 == ret)
{
close(h.fd);
return 1;
}
if (ICMP_ERR_PERMISSION == h.last_error)
return 0;
return -1;
}
/* Test 1: socket_create() success (skip without privileges) */ /* Test 1: socket_create() success (skip without privileges) */
Test(socket, create_success) Test(socket, create_success)

20
tests/test_helpers.h Normal file
View file

@ -0,0 +1,20 @@
#ifndef TEST_HELPERS_H
#define TEST_HELPERS_H
#include "icmp.h"
static inline int
has_net_raw_capability(void)
{
icmp_handle_t *h = icmp_create();
if (NULL != h)
{
icmp_destroy(h);
return 1;
}
return 0;
}
#endif